I cannot cry and it's everyone's problem

idk, I will mess with it later.

I may be able to help with that. The directory I believe is not writable and it may not be the default one. This change was made a long time ago when I realized some shady files were being uploaded and moved the directories out of worldly accessible areas. I'm not actively trying to fix this because its a minor problem that will probably go away when we do the next upgrade. If this is indeed the issue I'll try to carve out some time this week to log in and poke around a bit.

It's fixed, actually. But I think SCG had to change the code for it.
:sob:

I bet the file is read only then and corrupted.

Will Boydster return now?  :sob:

It's fixed, actually. But I think SCG had to change the code for it.
:sob:

It is "fixed" in the sense that you can make posts with it new, but the old posts with cry smilies won't work.

I bet the file is read only then and corrupted.

I don't think so. The file is still accessible directly, the smiley appears in the menu and a different code can be used for it. So it isn't corrupt.

The main issue is that the ' used in the smiley gets encoded by PHP as ' but the code to protect against malicious users parses this to determine what code it is (39) and then outputs it as '

This means the user submitted ' (') doesn't match the one used by the smiley code when it comes time to insert it (').

It has been fixed in 2.1.3 (or possibly earlier) by doing the same user input sanitation onto the smiley code.

Quote from: Alexei on March 15, 2023, 11:00:02 AM

It's fixed, actually. But I think SCG had to change the code for it.
:sob:

It is "fixed" in the sense that you can make posts with it new, but the old posts with cry smilies won't work.

 :sob:

Quote from: Alexei on March 15, 2023, 11:00:02 AM

It's fixed, actually. But I think SCG had to change the code for it.
:sob:

It is "fixed" in the sense that you can make posts with it new, but the old posts with cry smilies won't work.

Quote from: Username on March 15, 2023, 01:57:33 PM

I bet the file is read only then and corrupted.

I don't think so. The file is still accessible directly, the smiley appears in the menu and a different code can be used for it. So it isn't corrupt.

The main issue is that the ' used in the smiley gets encoded by PHP as ' but the code to protect against malicious users parses this to determine what code it is (39) and then outputs it as '

This means the user submitted ' (') doesn't match the one used by the smiley code when it comes time to insert it (').

It has been fixed in 2.1.3 (or possibly earlier) by doing the same user input sanitation onto the smiley code.

If this is something I can fix (I do not have access to the server, only the admin cp) and you know exactly what I need to do, you'll have to talk me through it. Like, step by step.

Sounds like the solution is as I originally thought - updating - which is my plan.

Sounds like the solution is as I originally thought - updating - which is my plan.

WOO HOO! SMF version 2.1.2  HERE WE GO!!!!!! 

Quote from: JackBlack on March 16, 2023, 12:48:59 AM

Quote from: Alexei on March 15, 2023, 11:00:02 AM

It's fixed, actually. But I think SCG had to change the code for it.
:sob:

It is "fixed" in the sense that you can make posts with it new, but the old posts with cry smilies won't work.

Quote from: Username on March 15, 2023, 01:57:33 PM

I bet the file is read only then and corrupted.

I don't think so. The file is still accessible directly, the smiley appears in the menu and a different code can be used for it. So it isn't corrupt.

The main issue is that the ' used in the smiley gets encoded by PHP as ' but the code to protect against malicious users parses this to determine what code it is (39) and then outputs it as '

This means the user submitted ' (') doesn't match the one used by the smiley code when it comes time to insert it (').

It has been fixed in 2.1.3 (or possibly earlier) by doing the same user input sanitation onto the smiley code.

If this is something I can fix (I do not have access to the server, only the admin cp) and you know exactly what I need to do, you'll have to talk me through it. Like, step by step.

Updating would be good, but until then, instructions from freshly installed SMF 2.0.19 (so some things I assume have already been done):

• Go to Admin->Forum->Smileys and Message Icons...
• Modify the smiley set
• Under Settings check "Enable customized smileys" and click Save (I assume this is already done).
• Go to "Add Smiley"
• Ensure "Use existing File" is selected
• Set it to "cry.gif"
• For Code, set it to ":'("
• Set Location to Hidden
• Press Save Changes

And because of previous changes, change the code from :sob: back to :'( for the other cry.gif which is there, or if you want everyone in the future to use :sob: leave that as is. Or you can have all three in there.

I also tried this on a server where the director was write protected, so I couldn't upload a new smiley, but it still allows me to make a new code for an existing smiley by the above process.

 Okay, I did all that, and I changed the first cry back to but it is still not working.



This is what the smiley and message icon page looks like (well I cut it off after the two cry smileys).

Maybe I should use use the code on the first one and set that one to hidden? Also, I left off the quotation marks because I assumed that is what you meant for me to do.



WAIT A MINUTE, I just previewed this post and the cry smiley is working.  Let's see if it still works after I post this. lol

IT WORKS!!  Thanks JackBlack.

Now boydster can cry again!!! 


I just went back over the thread and reread the instructions JackBlack gave the first time and now they make sense. lol

Glad that's sorted out. Sorry for the trouble folks.

IT WORKS!!  Thanks JackBlack.

Now boydster can cry again!!! 


I just went back over the thread and reread the instructions JackBlack gave the first time and now they make sense. lol

You're welcome. I especially like the Angry Yell smiley

I unhid the angry yell smiley, and a few others that are hidden, but we don't have images for them.

YES! IT WORKS AGAIN!
 
Testing yes.